search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Accepted changes to `README`, are my changes to `compile_list` what you expected? #144

Closed SimonGoring closed 10 years ago

SimonGoring commented 10 years ago

I think this is a tidier way of fixing the check issue for loading data.

gavinsimpson commented 10 years ago

@SimonGoring I'm not sure what you mean? You prefer pollen.equiv <- NULL? just be sure you realise this is not the way the R Gods have suggested this problem should be addressed.

karthik commented 10 years ago

That is exactly what the rgods have suggested. Even Dirk suggested the same thing recently.

SimonGoring commented 10 years ago

I as actually referring to the use of data(..., envir=environment()), but also yes, the NULL.

On Thu, Sep 25, 2014 at 9:13 PM, Karthik Ram notifications@github.com wrote:

That is exactly what the rgods have suggested. Even Dirk suggested the same thing recently.

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/pull/144#issuecomment-56911515.

gavinsimpson commented 10 years ago

@karthik Really? Got a link so I can see what they were suggesting? The globalVariables() thing is something R Core use internally for reference classes but assigning NULL is simpler to write so I'd be happy to go with that but I'd like to see the arguments.