ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

`get_chroncontrol` returns error for chronology id 1430 #178

Closed andydawson closed 9 years ago

andydawson commented 9 years ago

When I try to use get_chroncontrol to pull chronology with id 1430 I get the following:

Error in do.call(rbind.data.frame, lapply(aa, "[[", "controls")[[1]]) : second argument must be a list

The core is varved, but does have a chronology id so I don't know if it actually exists in the neotoma db as a geochron object or not.

@SimonGoring :)

SimonGoring commented 9 years ago

It's a varved record that doesn't seem to have depth associated with the varves. I'm going to check this a bit further but want to make some notes here:

SimonGoring commented 9 years ago

The fix for this is now in a new branch iss178. I'm going to leave it in the branch for a couple days. I'm not sure if having returning an error or an empty chroncontrol is the best option. If you want to check it out @andydawson let me know what you think.

SimonGoring commented 9 years ago

I've now merged the branch iss178 with the master branch as part of broader changes to get_chroncontrol. This issue is resolved.