search

ropensci / neotoma

Programmatic R interface to the Neotoma Paleoecological Database.
https://docs.ropensci.org/neotoma
Other
30 stars 16 forks source link

Command to open site in browser with Neotoma Explorer. #185

Closed SimonGoring closed 9 years ago

SimonGoring commented 9 years ago

It should be pretty straightforward, something like:

browse_dataset(datasetid = 7878)

should open Neotoma Explorer at this site. Presumably using browseURL.

gavinsimpson commented 9 years ago

Why not just browse()?

SimonGoring commented 9 years ago

That works too. I'm indifferent, I just want the functionality and wanted to remind myself to do it. Simpler is obviously better. On Jun 3, 2015 11:26, "Gavin Simpson" notifications@github.com wrote:

Why not just browse()?

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/issues/185#issuecomment-108510568.

gavinsimpson commented 9 years ago

Reasons other than "simpler" include being future proof if you implement as a S3 generic so you can add methods for other functions / data types (of that makes sense), not just a "dataset"

SimonGoring commented 9 years ago

That is a much better reason, thanks! I can add those methods right away anyways. Out of the box it should work with download and dataset objects. On Jun 3, 2015 15:49, "Gavin Simpson" notifications@github.com wrote:

Reasons other than "simpler" include being future proof if you implement as a S3 generic so you can add methods for other functions / data types (of that makes sense), not just a "dataset"

— Reply to this email directly or view it on GitHub https://github.com/ropensci/neotoma/issues/185#issuecomment-108612319.

SimonGoring commented 9 years ago

This was implemented in commit https://github.com/ropensci/neotoma/commit/6543f7110fa1ffabf3056e1c4b8b4b0fea801134. Not sure why I missed closing the issue.