get_geochron - Githubissues

I get the following error when using the get_geochron function:

> get_geochron(8444)
API call was successful.
[[1]]
Error in x[[1]]$site : $ operator is invalid for atomic vectors

Here is a second example:

> get_geochron(9282)
API call was successful.
[[1]]
Error in x[[1]]$site : $ operator is invalid for atomic vectors

To overcome this, I modified the function as so:

get_geochron.Mod = function (x, verbose = TRUE) 
{
  if (!is.numeric(x)) {
    stop("datasetid must be numeric.")
  }
  get_sample <- function(x) {
    base.uri <- "http://api.neotomadb.org/v1/apps/geochronologies/"
    aa <- try(fromJSON(paste0(base.uri, "?datasetid=", x), 
                       nullValue = NA))
    if (inherits(aa, "try-error")) 
      return(aa)
    if (isTRUE(all.equal(aa[[1]], 0))) {
      stop(paste("Server returned an error message:\n", 
                 aa[[2]]), call. = FALSE)
    }
    if (isTRUE(all.equal(aa[[1]], 1) & length(aa[[2]]) == 
                 0)) {
      stop("No geochronological record is associated with this sample", 
           call. = FALSE)
    }
    if (isTRUE(all.equal(aa[[1]], 1) & length(aa[[2]]) > 
                 0)) {
      aa <- aa[[2]]
      if (verbose) {
        message(strwrap(paste0("API call was successful.")))
      }
      pull.rec <- function(x) {
        data.frame(sample.id = x$SampleID, depth = x$Depth, 
                   thickness = x$Thickness, age.type = x$AgeType, 
                   age = x$Age, e.older = x$ErrorOlder, e.young = x$ErrorYounger, 
                   delta13C = x$Delta13C, lab.no = x$LabNumber, 
                   material.dated = x$MaterialDated, geo.chron.type = x$GeochronType, 
                   notes = x$Notes, infinite = x$Infinite, stringsAsFactors = FALSE)
      }
      out <- list(x, do.call(rbind.data.frame, lapply(aa[[1]], # Modification made
                                                      pull.rec)))
      #class(out) <- c("geochronologic", "list") # Modification made
    }
    out
  }
  lapply(x, function(x) try(get_sample(x)))
}

ropensci / neotoma

get_geochron #201