search

ropensci / nodbi

Document DBI connector for R
https://docs.ropensci.org/nodbi
Other
76 stars 6 forks source link

Working proposal for sqlite with json1 using RSQLite #24

Closed rfhb closed 5 years ago

rfhb commented 5 years ago

Hi, for small projects or exploring, it may be useful to have a simple solution for a JSON store. Since 2016, RSQLite ships with an sqlite version that includes the json1 extension json1 extension. This PR implements nodbi methods with RSQLite, in analogy to existing methods for other databases. If this is accepted, work could be done to implement the query parameter in docdb_query() (for the time being, this only implements a fields parameter, in analogy to mongolite). Thanks

rfhb commented 5 years ago

Re "All checks have failed": this is because of an issue with the couchdb related functions or the package it depends on (not the PR, which succeeds testing).

rfhb commented 5 years ago

Thanks for first review, sorry for inadvertently committing MongoDB related changes. Will address the comments in the next days. Yes, as mentioned, query is incomplete but wanted to hear back about the interest before spending more time.

The json1 extension is enabled and part of the RSQLite package (since version 1.1 / 2016, sorry this seems unclear from my initial message), reference.

sckott commented 5 years ago

sounds good. yes, interested in the query method

rfhb commented 5 years ago

Closed in favor of #25 for the new branch sqlite-addition.