search

ropensci / nodbi

Document DBI connector for R
https://docs.ropensci.org/nodbi
Other
76 stars 6 forks source link

Improved docdb_update() for src_sqlite() #31

Closed rfhb closed 4 years ago

rfhb commented 4 years ago

Hello, this is a PR to improve on my initial implementation of docdb_update() for src_sqlite() objects (PR #30 ). That implementation just replaced an existing record with a fully new record.

Now, json_patch() of the Json1 extension in the SQLite backend is used to enable atomic updates (of parts of the JSON document), see https://www.sqlite.org/json1.html#jpatch.

This is much more appropriate for an docdb_update() method, and I hope you can accept this. Thanks for review and comments.

sckott commented 4 years ago

having a look

sckott commented 4 years ago

LGTM