Handling exceptions - Githubissues

mbojan commented 8 years ago

I think currently only HTTP errors are handled through httr::stop_for_status in while_oai.

mbojan commented 8 years ago

Ah, there is handle_errors... Sorry!

mbojan commented 8 years ago

Actually, I think this could be improved:

handle_errors takes XML as a character vector, parses it with read_xml to check for <error> tag. The XML is then parsed again outside of handle_errors in both get_record and while_oai. This seems inefficient.
More serious problem. Sometimes the XML can be malformed. I encountered it when working with my OAI-PMH source: some records contain UTF-8 characters that are unacceptable by XML and xml2::read_xml trips over (it is actually libxml that throws an error). I think requesting raw results could (optionally?) work with text without XML parsing.

sckott commented 8 years ago

That sounds good, the change to handle_errors()

mbojan commented 8 years ago

Closing because handle_errors has been updated. Discussion of other ideas moved largely to #17

ropensci / oai