search

ropensci / oai

OAI-PMH R client
https://docs.ropensci.org/oai
Other
14 stars 4 forks source link

Read xml safely #14

Closed mbojan closed 9 years ago

mbojan commented 9 years ago

I mentioned this in #10: https://github.com/sckott/oai/issues/10#issuecomment-143072521

When parsing an XML containing illegal characters libxml throws an error like

PCDATA invalid Char value 25 [9]

read_xml_safely catches the error, removes the characters, and gives a warning.

See also: http://stackoverflow.com/questions/26938905/perl-xmllibxml-parsing-issue-of-invalid-char

mbojan commented 9 years ago

Hmm... I see that Travis failed. I wonder why because tests and checks passed on my machine.

sckott commented 9 years ago

only an older version of R (3.1.3) failed, the current stable and devel passed, looking into why it failed

mbojan commented 9 years ago

Fixed. Tests pass now. Ready to merge.

mbojan commented 9 years ago

Well, the tests passed when I connected travis on my fork... https://travis-ci.org/mbojan/oai/builds/82702942

It failed now for rdevel. Seems like downloading covr failed :(

mbojan commented 9 years ago

Meanwhile, I found some bugs. Let's hold on with that PR.

I am closing this and I will resubmit later.

sckott commented 9 years ago

okay, thanks