Handling http errors - Githubissues

ropensci / oai

OAI-PMH R client

https://docs.ropensci.org/oai

Other

14 stars 4 forks source link

Handling http errors #23

Closed mbojan closed 5 years ago

mbojan commented 9 years ago

Extracted from #17.

Internet-related errors, like timeouts etc. They are thrown by httr::GET, which is used in several places, but most importantly in while_oai, which is the core of list_* functions.

Things like timeouts could be addressed by proper pre-configuring httr::GET (passing additional arguments through httr::config
Perhaps it should be possible to add an optional sleep time between requests in while_oai.

sckott commented 5 years ago

... is passed through to while_oai() so i think the user can configure this themselves. or do you think we need more than ...?

mbojan commented 5 years ago

I think ... should be enough in most cases. I vaguely recall that at some point I was getting some errors and thought it was because I was making to many request too quickly, hence the second bullet above. However I think the problem was somewhere else in the end.

I believe we can close this one.

sckott commented 5 years ago

ok, thanks, closing