ropensci / openalexR

Getting bibliographic records from OpenAlex
https://docs.ropensci.org/openalexR/
Other
91 stars 20 forks source link

CRAN patch request to use string for comparing package versions #125

Closed yjunechoe closed 1 year ago

yjunechoe commented 1 year ago

Hi team -

Yesterday I received a CRAN email asking us to use string for comparing package versions for one of my own packages, and saw openalexR on the list as well. I realized that I was responsible for this in how I wrote oa_ngrams() - apologies!

This is a small PR to use "5" instead of 5 when checking for {curl} version. So it's now:

utils::packageVersion("curl") >= "5"

I also added a comment for CRAN telling them that we fixed it.

Thanks!