Release openalexR 1.2.3

ropensci / openalexR

Getting bibliographic records from OpenAlex

https://docs.ropensci.org/openalexR/

Other

97 stars 21 forks source link

Release openalexR 1.2.3 #191

Closed massimoaria closed 10 months ago

massimoaria commented 10 months ago

Prepare for release:

[x] git pull
[x] Check current CRAN check results
[x] Polish NEWS
[x] urlchecker::url_check()
[x] devtools::build_readme()
[x] devtools::check(remote = TRUE, manual = TRUE)
[x] devtools::check_win_devel()
[x] revdepcheck::revdep_check(num_workers = 4)
[x] Update cran-comments.md
[x] git push

Submit to CRAN:

[ ] usethis::use_version('patch')
[x] devtools::submit_cran()
[x] Approve email

Wait for CRAN...

[x] Accepted :tada:
[ ] usethis::use_github_release()
[ ] usethis::use_dev_version(push = TRUE)

massimoaria commented 10 months ago

@trangdata @yjunechoe

devtools::build_readme() returns an error.

ℹ Installing openalexR in temporary library
ℹ Building /Users/massimoaria/Rpackages/openalexR/README.Rmd

Quitting from lines 190-203 [unnamed-chunk-12] (README.Rmd)
Error in item$last_known_institution : 
  $ operator is invalid for atomic vectors
Error: 
! in callr subprocess.
Caused by error in `item$last_known_institution`:
! $ operator is invalid for atomic vectors
ℹ See `$stdout` for standard output.
Type .Last.error to see the more details.

We are not able to build readme because the following lines don't work:

_my_arguments <- list( entity = "authors", last_known_institution.id = "I71267560", works_count = ">499" ) do.call(oa_fetch, c(my_arguments, list(countonly = TRUE)))

The issue appears only when you set count_only = TRUE

massimoaria commented 10 months ago

I proposed a commit that solves this issue