ropensci / openalexR

Getting bibliographic records from OpenAlex
https://docs.ropensci.org/openalexR/
Other
89 stars 19 forks source link

Progress bar without verbose #215

Closed rkrug closed 3 months ago

rkrug commented 4 months ago

Hi

it would be great to have in oa_fetch() and oa_request() an additional argument named progress which would indicate if a progress bar is shown. It could be a character vector, which would make it future proof to include other progress indictor options.

trangdata commented 3 months ago

So I know we had a similar discussion in #127, but could you elaborate on why you wouldn't want verbose = TRUE? To shorten the printed query URL, you can set the environment variable openalexR.print to the number of characters to print: Sys.setenv(openalexR.print = 70). Echoing @yjunechoe's previous comment that we want to be mindful of balancing convenience for the maintainer vs. the user.

rkrug commented 3 months ago

OK - that would work. But in my understanding, verbose implies diagnostic output, while progress implies convenience / information output. So these are two different things for me. But I see your point.

trangdata commented 3 months ago

Ah I see. In my head, verbose has a more general meaning, essentially just message outputs of a function to the user.

FWIW I'm noting a few helpful discussions re different levels of "verbosity" here:

I think the behavior of openalexR's current verbose implementation is fine, but I welcome a new issue tagged for enhancements with clear discussion of how to implement different levels of verbosity and why that is helpful.