search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
314 stars 45 forks source link

Checks in osmdata_* to intercept not implemented query types #300

Closed jmaspons closed 1 year ago

jmaspons commented 1 year ago

stop cases that crash and warnings for incomplete results.

mpadge commented 1 year ago

Thanks, that's a great addition. I'll just wait until I've merged #298, then merge that over here before finally merging this one again.

jmaspons commented 1 year ago

Ok, I see that you are doing good progress there. Perhaps we can remove many of the errors and warnings from this PR, which is great!

jmaspons commented 1 year ago

Testing the osmdata_* functions again, I see that the changes for implementing meta queries in C++ for osmdata_data_frame doesn't affect the other function. Thus, I think it's OK to merge this PR until addressed

jmaspons commented 1 year ago

separate that code which is repeated three times into a separate function

Done! @mpadge