search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
314 stars 45 forks source link

Update docs and dependencies #302

Closed jmaspons closed 1 year ago

jmaspons commented 1 year ago

Added missing osmdata_* functions, silicate as a suggested dependency and sp moved from imported to suggested

mpadge commented 1 year ago

@jmaspons Once you address the above, i'll happily approve and merge. I also wanted to arrange a video chat with you, mostly so that i can express my gratitude for all of your work. I don't have contact details for you, so can you please either email me, or you should be able to book a meeting at cal.com / markpadgham. Thanks.

jmaspons commented 1 year ago

Hopfully solved! I'll contact you, @mpadge . Let's find some day for next week

jmaspons commented 1 year ago 
==> Rcpp::compileAttributes()

* Updated R/RcppExports.R
Warning message:
The following packages are referenced using Rcpp::depends attributes however are not listed in the Depends, Imports or LinkingTo fields of the package DESCRIPTION file: sp

Perhaps it requires some more work to move sp to suggested packages

mpadge commented 1 year ago

Sorry, that's my fault. Just need to delete this line: https://github.com/ropensci/osmdata/blob/85cd6954d1e007b0a910195ac941124546fe3898/src/osmdata-sp.cpp#L430 That was just there for some historical reason I can no longer remember, but is no longer needed.

mpadge commented 1 year ago

Thanks @jmaspons. One more thing that generally needs to be done is to update the NEWS file. I'll merge for now and do that straight away, but we should both try to remember to always update NEWS with each PR :grinning: