search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
317 stars 45 forks source link

Split get-osmdata.R #306

Closed jmaspons closed 1 year ago

jmaspons commented 1 year ago

Fix #304. fill_objects function renamed to fill_sf_objects

I found that getbb_sc function is not used anywhere. Perhaps it can help to fix #290 ? Moved to osmdata_sc.R

get_meta_from_cpp_output kept in get-osmdata.R despite that currently it's only used in osmdata_data_frame, but can be useful if out meta queries are implemented for osmdata_sf and others.

mpadge commented 1 year ago

That's great @jmaspons. As always: I really appreciate your help here, and thanks for acting so quickly on this one. BTW When you open a PR you can clik on the "Reviewers" symbol on the upper right, and request that i review and approve before merging. I should also change the repo settings so that only reviewed and approved PRs can be merged. We can do a trial run first before switching that on. I'm also happy to grant you admin rights here, so you can merge PRs as well. All things we can discuss elsewhere (slack).