search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
317 stars 45 forks source link

Add parameters from `oqp` to `opq_osm_id` #320

Closed jmaspons closed 1 year ago

jmaspons commented 1 year ago

Hi and thanks for the feedback, @mpadge!

My assumption for the text of the messages is that people using osmdata_sp/sf/sc are really interested in the spatial data, thus the message points to changes in the query. Perhaps we can add the tip to use osmdata_xml/data_frame, as explained in ?opq details. Is that OK?

mpadge commented 1 year ago

Hi and thanks for the feedback, @mpadge!

My assumption for the text of the messages is that people using osmdata_sp/sf/sc are really interested in the spatial data, thus the message points to changes in the query. Perhaps we can add the tip to use osmdata_xml/data_frame, as explained in ?opq details. Is that OK?

Yeah, sorry, I should have explained better, but that was exactly what I meant. Just adding some extra information to current errors/warnings.

jmaspons commented 1 year ago

I improved the messages, @mpadge. Ready to merge now?