Closed jmaspons closed 1 year ago
@mpadge do you think we can omit the rhub fails for the release? It seems that will be removed from the checklist anyway https://github.com/r-lib/usethis/pull/1773
You will receive a mail about the devtools::check_win_devel()
cause only mails from maintainers are allowed.
Thanks! Definitely don't worry about rhub fails. But definitely do worry about anything reported on r-winbuilder, including this (temporary link, 2023-04-23). That also appears to have only run one win-builder check. It's important to run all 3. I usually just do that myself at the base URL in the link.
In this case, i see you're using revdep, so you'll need to modify .Rbuildignore
to exclude that directory for this to pass. I also always create a local zip and then manually check all the contents just to make sure there's nothing there that ought not be.
Ok, I saw the problem with revdep
when sending the win-builder check and fix it with https://github.com/ropensci/osmdata/commit/fbda18c886c9253fac6aad4b2632d96f2581d62d
win-builder with R-oldrelease, R-release is running. Check your inbox, @mpadge
I updated the cran-comments and I think it's ready to submit
Also need win-builder with r-dev; can you please also submit that? I'll let you know here as soon as all reports are in.
Also need win-builder with r-dev; can you please also submit that? I'll let you know here as soon as all reports are in.
Done!
Released 🎉
Fabulous! Thank you :tada:
Prepare for release:
git pull
devtools::build_readme(output_format="md_document")
urlchecker::url_check()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
devtools::check_win_release()
devtools::check_win_oldrelease()
rhub::check_for_cran()
(2/4 fail: ubuntu-gcc-release and linux-x86_64-rocker-gcc-san)rhub::check(platform = 'ubuntu-rchk')
(fail)rhub::check_with_sanitizers()
(fail)revdepcheck::revdep_check(num_workers = 4)
cran-comments.md
git push
Submit to CRAN:
usethis::use_version('patch')
devtools::submit_cran()
Wait for CRAN...
git push
usethis::use_github_release()
usethis::use_dev_version()
git push