search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
314 stars 45 forks source link

upcoming PROJ/reproj breaks tests #340

Closed mdsumner closed 2 months ago

mdsumner commented 3 months ago

I need to release a new combo of reproj/PROJ, and this unfortunately breaks this test:

  ── Error ('test-trim.R:80:5'): bb_poly as sf/sc ────────────────────────────────
  Error in `do.call(cbind, out)`: second argument must be a list
  Backtrace:
      ▆
   1. └─osmdata::trim_osmdata(x0, bb, exclude = FALSE) at test-trim.R:80:5
   2.   └─osmdata:::trim_osmdata_sfp(dat = dat, bb_poly = bb_poly, exclude = exclude)
   3.     ├─reproj::reproj(bb_poly, target = crs, source = srcproj)
   4.     └─reproj:::reproj.matrix(bb_poly, target = crs, source = srcproj)
   5.       ├─base::cbind(do.call(cbind, out), 0)
   6.       └─base::do.call(cbind, out)

I will let CRAN know and come back here with PR/s when they are both updated.

mpadge commented 3 months ago

Cool, thanks Mike. I love me an auto-fixing bug report ...

mdsumner commented 2 months ago

we good, sorry for noise I was quite worried and uncertain