search

ropensci / osmdata

R package for downloading OpenStreetMap data
https://docs.ropensci.org/osmdata
317 stars 45 forks source link

Default plot method for osmdata class #77

Closed Robinlovelace closed 5 years ago

Robinlovelace commented 7 years ago

Would be useful for users if this did not generate an error:

library(osmdata)
#> Data (c) OpenStreetMap contributors, ODbL 1.0. http://www.openstreetmap.org/copyright
q = add_feature(opq = opq("Ireland"), key = "left:nation", value = "Northern Ireland")
res = osmdata_sf(q = q)
class(res)
#> [1] "list"    "osmdata"
plot(res)
#> Error in xy.coords(x, y, xlabel, ylabel, log): 'x' is a list, but does not have components 'x' and 'y'
mpadge commented 7 years ago

Totally agree! Do you think it'd be worth adding osmplotr as a dependency and simply passing everything there? It'd make instant plots that would look quite nice.

Robinlovelace commented 7 years ago

Yes that sounds like a good solution.

mpadge commented 7 years ago

@Robinlovelace big things afoot in this dept! I'm working on a new package currently called svgplotr. It includes a prototype for svg overlays directly on leaflet via d3. I'll get a full-scale demo up hopefully tomorrow, but it scales and can do ... dunno, reckon at least 100,000's of lines. This will not only be the perfect default plot method for osmdata, but will be your ultimate solution for pct. Because they are vector objects, each line will also be able to be queried. It's gunna be big!

mpadge commented 5 years ago

I'm thinking of just having mapdeck as the default viz option, but it might be a better idea to first write an additional vignette on different approaches to visualising OSM data, and use that to more systematically explore the pro's and con's of different approaches.

mpadge commented 5 years ago

Closed for the moment in favour of #155. A plot method might be implemented following the vignette, but first things first.