ropensci / osmplotr

Data visualisation using OpenStreetMap objects
https://docs.ropensci.org/osmplotr
135 stars 21 forks source link

Error with print_osm_map #41

Closed maelle closed 6 years ago

maelle commented 6 years ago

Noticed this while preparing a blog post that'll feature the very cool osmdata and osmplotr 😉 I'm using ggplot2 latest version, maybe that's the issue, but I don't see anything amiss on CRAN. 🤔

library("osmplotr")
#> Data (c) OpenStreetMap contributors, ODbL 1.0. http://www.openstreetmap.org/copyright
bbox <- get_bbox (c(-0.15, 51.5, -0.10, 51.52))
map <- osm_basemap (bbox = bbox, bg = 'gray20')
print_osm_map (map)
#> Error: Discrete value supplied to continuous scale

Created on 2018-07-09 by the reprex package (v0.2.0).

Session info ``` r devtools::session_info() #> Session info ------------------------------------------------------------- #> setting value #> version R version 3.5.0 (2018-04-23) #> system x86_64, mingw32 #> ui RTerm #> language (EN) #> collate English_United States.1252 #> tz Europe/Paris #> date 2018-07-09 #> Packages ----------------------------------------------------------------- #> package * version date source #> abind 1.4-5 2016-07-21 CRAN (R 3.5.0) #> assertthat 0.2.0 2017-04-11 CRAN (R 3.5.0) #> backports 1.1.2 2017-12-13 CRAN (R 3.5.0) #> base * 3.5.0 2018-04-23 local #> bindr 0.1.1 2018-03-13 CRAN (R 3.5.0) #> bindrcpp 0.2.2 2018-03-29 CRAN (R 3.5.0) #> class 7.3-14 2015-08-30 CRAN (R 3.5.0) #> colorspace 1.3-2 2016-12-14 CRAN (R 3.5.0) #> compiler 3.5.0 2018-04-23 local #> curl 3.2 2018-03-28 CRAN (R 3.5.0) #> datasets * 3.5.0 2018-04-23 local #> deldir 0.1-15 2018-04-01 CRAN (R 3.5.0) #> devtools 1.13.5 2018-02-18 CRAN (R 3.5.0) #> digest 0.6.15 2018-01-28 CRAN (R 3.5.0) #> dplyr 0.7.5 2018-05-19 CRAN (R 3.5.0) #> e1071 1.6-8 2017-02-02 CRAN (R 3.5.0) #> evaluate 0.10.1 2017-06-24 CRAN (R 3.5.0) #> ggm 2.3 2015-01-21 CRAN (R 3.5.1) #> ggplot2 3.0.0 2018-07-03 CRAN (R 3.5.1) #> glue 1.2.0.9000 2018-06-28 Github (tidyverse/glue@a2c0f8b) #> goftest 1.1-1 2017-04-03 CRAN (R 3.5.0) #> graphics * 3.5.0 2018-04-23 local #> grDevices * 3.5.0 2018-04-23 local #> grid 3.5.0 2018-04-23 local #> gtable 0.2.0 2016-02-26 CRAN (R 3.5.0) #> htmltools 0.3.6.9001 2018-06-16 Github (rstudio/htmltools@3aee819) #> httr 1.3.1 2017-08-20 CRAN (R 3.5.0) #> igraph 1.2.1 2018-03-10 CRAN (R 3.5.0) #> jsonlite 1.5 2017-06-01 CRAN (R 3.5.0) #> knitr 1.20 2018-02-20 CRAN (R 3.5.0) #> lattice 0.20-35 2017-03-25 CRAN (R 3.5.0) #> lazyeval 0.2.1 2017-10-29 CRAN (R 3.5.0) #> lubridate 1.7.4 2018-04-11 CRAN (R 3.5.0) #> magrittr 1.5 2014-11-22 CRAN (R 3.5.0) #> mapproj 1.2.6 2018-03-29 CRAN (R 3.5.0) #> maps 3.3.0 2018-04-03 CRAN (R 3.5.0) #> Matrix 1.2-14 2018-04-13 CRAN (R 3.5.0) #> memoise 1.1.0 2017-04-21 CRAN (R 3.5.0) #> methods * 3.5.0 2018-04-23 local #> mgcv 1.8-23 2018-01-21 CRAN (R 3.5.0) #> munsell 0.5.0 2018-06-12 CRAN (R 3.5.0) #> nlme 3.1-137 2018-04-07 CRAN (R 3.5.0) #> osmdata 0.0.7 2018-05-17 CRAN (R 3.5.0) #> osmplotr * 0.3.0.99 2018-07-09 local #> pillar 1.2.3 2018-05-25 CRAN (R 3.5.0) #> pkgconfig 2.0.1 2017-03-21 CRAN (R 3.5.0) #> plyr 1.8.4 2016-06-08 CRAN (R 3.5.0) #> polyclip 1.9-0 2018-06-14 CRAN (R 3.5.0) #> purrr 0.2.5 2018-05-29 CRAN (R 3.5.0) #> R6 2.2.2 2017-06-17 CRAN (R 3.5.0) #> Rcpp 0.12.17 2018-05-18 CRAN (R 3.5.0) #> rgeos 0.3-28 2018-06-08 CRAN (R 3.5.1) #> rlang 0.2.1 2018-05-30 CRAN (R 3.5.0) #> rmarkdown 1.10 2018-06-11 CRAN (R 3.5.0) #> rpart 4.1-13 2018-02-23 CRAN (R 3.5.0) #> rprojroot 1.3-2 2018-01-03 CRAN (R 3.4.3) #> rvest 0.3.2 2016-06-17 CRAN (R 3.4.0) #> scales 0.5.0 2017-08-24 CRAN (R 3.5.0) #> sp 1.3-1 2018-06-05 CRAN (R 3.5.0) #> spatstat 1.56-0 2018-06-15 CRAN (R 3.5.1) #> spatstat.data 1.3-1 2018-06-11 CRAN (R 3.5.1) #> spatstat.utils 1.8-2 2018-06-14 CRAN (R 3.5.1) #> stats * 3.5.0 2018-04-23 local #> stringi 1.2.3 2018-06-12 CRAN (R 3.5.0) #> stringr 1.3.1 2018-05-10 CRAN (R 3.5.0) #> tensor 1.5 2012-05-05 CRAN (R 3.4.0) #> tibble 1.4.2 2018-01-22 CRAN (R 3.5.0) #> tidyselect 0.2.4 2018-02-26 CRAN (R 3.5.0) #> tools 3.5.0 2018-04-23 local #> utils * 3.5.0 2018-04-23 local #> withr 2.1.2 2018-03-15 CRAN (R 3.4.4) #> xml2 1.2.0 2018-01-24 CRAN (R 3.5.0) #> yaml 2.1.19 2018-05-01 CRAN (R 3.5.0) ```
maelle commented 6 years ago

Oh it's just because you can't plot an empty map sorry 🤦‍♀️

mpadge commented 6 years ago

Yeah, you figured it out right. I'll look out for the blog - how exciting for me! I also just landed in Brisbane for User18. Also exciting!

maelle commented 6 years ago

Have an awesome time at UseR!

I'll probably send my code your way when I'm done, for a short review 👼

mpadge commented 6 years ago

Yes please!!!

JosiahParry commented 2 years ago

I'm running into this issue presently. I'm not able to understand why I cannot simply create a base map and add it to a ggplot that does not use any other OSM data.

Is osmplotr::osm_basemap() just an empty ggplot layer?