search

ropensci / osmplotr

Data visualisation using OpenStreetMap objects
https://docs.ropensci.org/osmplotr
132 stars 21 forks source link

figs not rendering on docs.ropensci #54

Open mpadge opened 4 years ago

mpadge commented 4 years ago

even though all is good on ropensci.github.io. Figures in the README, that is.

mpadge commented 4 years ago

@jeroen please check out the commit referenced above. This was necessary to get images in man/figures to render on docs.ropensci.org. It would seem that links given as ![](./man/figure/*.png) do not work for docs, even though they are parsed fine via travis deployment to ropensci.github.org. I had to change them all to html <img src ...> calls to get them to load properly. Looks like something to fix on your side?

And while we're here - does the docs server have a public-facing log? That would be useful for anyone trying to address issues like this, to be able to see what might have gone wrong. Thanks!

jeroen commented 4 years ago

The build logs are on https://dev.ropensci.org/job/osmplotr/ and output docs are hosted on https://github.com/ropensci-docs/osmplotr

I'm not sure why the links didn't work, do you remember what they link would point to in the html ?

jeroen commented 4 years ago

Perhaps you just had to remove the ./ prefix on the paths? Can you look at how drake is doing this?