ropensci / parzer

Parse geographic coordinates
https://docs.ropensci.org/parzer
Other
63 stars 6 forks source link

Problem with test-mbcs-locale #33

Closed sckott closed 3 years ago

sckott commented 3 years ago

@yutannihilation was about to submit a new version to CRAN, but winbuilder checks are failing on the dev version here - do we just skip on cran? or skip based on some other criterion?

https://win-builder.r-project.org/GOaVR3yY049j/00check.log https://win-builder.r-project.org/SED57TL7sYki/00check.log

Loading required package: parzer
  == Failed tests =================
  -- Error (test-mbcs-locale.R:43:3): parse_lat() doesn't hang on Japanese locale --
  Error: No root directory found in d:/RCompile/CRANguest/R-devel/parzer.Rcheck/tests_i386/testthat or its parent directories. Root criterion: contains a file "DESCRIPTION"
  Backtrace:
      x
   1. \-pkgbuild::compile_dll(".", force = TRUE) test-mbcs-locale.R:43:2
   2.   \-pkgbuild:::pkg_path(path)
   3.     \-rprojroot::find_root("DESCRIPTION", path)

  [ FAIL 1 | WARN 0 | SKIP 30 | PASS 11 ]
  Error: Test failures
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... [2s] OK
* checking PDF version of manual ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 2 ERRORs
yutannihilation commented 3 years ago

Hmm, I didn't expect the test would fail in this way, sorry... Just quickly investigated if there's a way to run this without pkgbuild::compile_dll(), but I couldn't find any, so I'm afraid there's no choice but to skip on CRAN.

sckott commented 3 years ago

ok, will do

yutannihilation commented 3 years ago

Thanks!