search

ropensci / patentsview

An R client to the PatentsView API
https://docs.ropensci.org/patentsview
Other
32 stars 9 forks source link

Possible API sunset date? #35

Open mustberuss opened 2 months ago

mustberuss commented 2 months ago

This was in today's patentsview newsletter: IMPORTANT NOTICE: The PatentsView Legacy API will be retired on Feb. 12, 2025. We encourage users still using the Legacy API to begin converting to our new PatentSearch API as early as possible to avoid any potential downtime.

The new version of the API is still buggy so who knows how firm that date is.

I could submit a PR to get the tests passing again, I noticed they failed on Maëlle's PR. Or can the in-progress PR be salvaged?

crew102 commented 2 months ago

Hey Russ, thanks for the heads up on this. I'd like to wait for the new version to settle down as much as possible before we do more on porting things over. Can we revisit this closer to the deadline?

mustberuss commented 2 months ago

Sure, waiting is fine. The tests are passing in my repo, I've been doing pushes as they've made changes.

One thing I didn't catch initially is that they've changed the name of the API with this most recent release. Not sure if that has any bearing on the R package. Can we be the package formerly known as patentsview or something?

crew102 commented 2 months ago

Oh interesting. I'd probably say let's just keep it as patentsview and make a note about the name discrepancy.

Re: your repo, how much of the functionality that's in original patentsview package do you have working with the new version of the API?

On Fri, Aug 30, 2024 at 11:04 PM Russ Allen @.***> wrote:

Sure, waiting is fine. The tests are passing in my repo, I've been doing pushes as they've made changes.

One thing I didn't catch initially is that they've changed the name https://search.patentsview.org/docs/2024/08/28/2.1.3-release of the API with this most recent release. Not sure if that has any bearing on the R package. Can we be the package formerly known as patentsview or something?

— Reply to this email directly, view it on GitHub https://github.com/ropensci/patentsview/issues/35#issuecomment-2322744196, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVTOOM3OFHR2MJFMGA3M63ZUEXEXAVCNFSM6AAAAABNJFCFBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSG42DIMJZGY . You are receiving this because you commented.Message ID: @.***>

mustberuss commented 2 months ago

It's all working to the extent it can. There's a new endpoint that is totally broken and on some endpoints you can't request all the fields without an error being thrown. I have tests that will fail when bugs are fixed and I've tried to keep the code working and tests passing as they've made changed. I've also reworked the vignettes and added a few new ones, they're published on my github pages.

crew102 commented 1 month ago

That's great, thanks for keeping up on this!

On Mon, Sep 2, 2024 at 7:26 PM Russ Allen @.***> wrote:

It's all working to the extent it can. There's a new endpoint that is totally broken and on some endpoints you can't request all the fields without an error being thrown. I have tests that will fail when bugs are fixed and I've tried to keep the code working and tests passing as they've made changed. I've also reworked the vignettes and added a few new ones, they're published on my github pages.

— Reply to this email directly, view it on GitHub https://github.com/ropensci/patentsview/issues/35#issuecomment-2325377612, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVTOOKFW4YXJ75TH6V3D6DZUTX2ZAVCNFSM6AAAAABNJFCFBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGM3TONRRGI . You are receiving this because you commented.Message ID: @.***>