search

ropensci / pdftools

Text Extraction, Rendering and Converting of PDF Documents
https://docs.ropensci.org/pdftools
Other
524 stars 71 forks source link

Use `poppler` in SystemRequirements #85

Closed schloerke closed 4 years ago

schloerke commented 4 years ago

Should trigger https://github.com/rstudio/r-system-requirements/blob/af9231b2b29caceaeff14fa7cff80d1e8f9d36cb/rules/poppler.json

(untested)

jeroen commented 4 years ago

I don't understand, would you want me to remove those package names?

schloerke commented 4 years ago

This was my misunderstanding / bug in my codes. When installing on a clean docker file I ran into an issue. But if the code below works (which it does), I am happy. 

# In pdftools root folder
remotes::system_requirements("ubuntu", "16.04")
#> [1] "apt-get install -y libpoppler-cpp-dev"   "apt-get install -y libcurl4-openssl-dev"
#> [3] "apt-get install -y libssl-dev"           "apt-get install -y libjpeg-dev"
#> [5] "apt-get install -y libpng-dev"           "apt-get install -y libwebp-dev"
#> [7] "apt-get install -y libleptonica-dev"     "apt-get install -y libtesseract-dev"

Sorry for the false alarm. This is what I get for not testing. 😞