ropensci / photosearcher

Searches Flickr for photographs and metadata
https://docs.ropensci.org/photosearcher
15 stars 13 forks source link

Fix bug in test_download #2

Closed AugustT closed 5 years ago

AugustT commented 5 years ago

I think this is because on Travis you don't have write permissions tot he location this test was trying to write to. i have changed it to the temp directory

AugustT commented 5 years ago

Lets see if it fixes the test...

AugustT commented 5 years ago

@laurajanegraham - because it looks like you are working on this at the same time

laurajanegraham commented 5 years ago

Ahhhh, thank you.

On Fri, 17 May 2019 at 12:19, Dr Tom August notifications@github.com wrote:

Lets see if it fixes the test...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nfox29/photosearcher/pull/2?email_source=notifications&email_token=ABIUBREFZ6YRTAIJGTIVRNLPV2IFNA5CNFSM4HNUMOZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUPRMI#issuecomment-493418673, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIUBRF7HYETASCJP6RT44TPV2IFNANCNFSM4HNUMOZQ .

-- Dr Laura Graham Postdoctoral Research Associate Geography and Environment University of Southampton @laurajanegraham http://laurajanegraham.github.io/ SCALEFORES Project Page http://www.southampton.ac.uk/geography/research/projects/scalefores.page

laurajanegraham commented 5 years ago

No, I've done the worst thing - broken it all then abandoned it... I've not got a change to work on it today.

On Fri, 17 May 2019 at 12:20, Dr Tom August notifications@github.com wrote:

@laurajanegraham https://github.com/laurajanegraham - because it looks like you are working on this at the same time

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nfox29/photosearcher/pull/2?email_source=notifications&email_token=ABIUBRB7D2URON66T3V645LPV2II5A5CNFSM4HNUMOZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUPTIQ#issuecomment-493418914, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIUBRA7EPSM6CCMANQVA33PV2II5ANCNFSM4HNUMOZQ .

-- Dr Laura Graham Postdoctoral Research Associate Geography and Environment University of Southampton @laurajanegraham http://laurajanegraham.github.io/ SCALEFORES Project Page http://www.southampton.ac.uk/geography/research/projects/scalefores.page

AugustT commented 5 years ago

It looks like the functionality of one of the APIs has changed

base_url= 'https://api.flickr.com/services/rest/?method=flickr.photos.search&api_key=6a2ac025703c4b98aae141842eae8b1d'
r <- httr::GET(paste(base_url))
Response [https://api.flickr.com/services/rest/?method=flickr.photos.search&api_key=6a2ac025703c4b98aae141842eae8b1d]
  Date: 2019-05-17 12:36
  Status: 200
  Content-Type: text/xml; charset=utf-8
  Size: 176 B
<?xml version="1.0" encoding="utf-8" ?>
<rsp stat="fail">
    <err code="3" msg="Parameterless searches have been disabled. Please u...
</rsp>