ropensci / phylocomr

Phylocom R interface
https://docs.ropensci.org/phylocomr
Other
15 stars 7 forks source link

feedback #2

Closed sckott closed 6 years ago

sckott commented 7 years ago

@cboettig @fmichonneau @Pakillo @wcornwell (and let anyone else know that uses phylocom a lot)

curious to get feedback on this - if you use Phylocom that is, if not, nevermind :)

Jeroen was good enough to wrap Phylocom in R for us, - that is, it ships with the package, so works across operating systems. - no need to require users to install it separately. unfortunately, it's not ideal situation since we don't link to it via Rcpp like a proper C library, we just call the executables, but its best we can do, and better than shelling out separately.

I've been working on higher level interfaces to each of the things one can do with Phylocom. Look at the readme https://github.com/ropensci/phylocomr#phylocomr for some examples. Not all higher level things are done yet

Thoughts? Feedback?

one usecase I need it for right now is in the brranching package to call phylomatic locally for when users have massive species lists https://github.com/ropensci/brranching/blob/master/R/phylomatic_local.R

wcornwell commented 7 years ago

hi @sckott, be good to check with @skembel on this. I think most of the functionality got ported to https://github.com/skembel/picante , and there are some newer methods for some of the stuff in phylocom , but I don't have a complete overview.

sckott commented 7 years ago

Thanks @wcornwell - Im not up on how much of phylocom functionaluty is in picante. And I assume picante is pure R? So possibly speed improvement wrapping the C library?

And I don't think phylomatic or bladj are in picante

wcornwell commented 7 years ago

also good to check with @camwebb :) Hi Cam!

skembel commented 7 years ago

Some but not all of the functionality in phylocom was ported to the picante package in R.

camwebb commented 7 years ago

Thanks for phylocomr! I think Steve answered everything, but let me know if I can help. phylocom and phylomatic are both due for major updates. Maybe you can tell me something that might push this up the TODO list! :-)

sckott commented 7 years ago

@skembel thanks!

I'll make notes in the docs letting users know where using picante is better/easier

sckott commented 7 years ago

@camwebb thanks for phylocom!

phylocom and phylomatic are both due for major updates.

Any features/behavior you know about already? Is the API to phylocom going to change at all, or only internals and/or parameters/flags?

Do you have a target date for release yet?

Maybe you can tell me something that might push this up the TODO list!

What kinds of things are you looking for?

camwebb commented 7 years ago

Main thing to fix on phylocom is the tree output, which gags on large trees. I finally worked out what was happening. I was using a recursive function to attach parenthetical 'branches' from the root out, but with large trees this maxxed out the stack depth (not a memory issue per se). Need to go back to a single stream of character concatenation (as it was in the earlier versions).

Not sure what you mean by the API. The CLI flags, arguments won't change though there might be some new flags.

No release date yet. Just starting to think about this!

Thx

sckott commented 7 years ago

Not sure what you mean by the API.

The user facing methods (e.g., aot, ecovolve, etc.). I ask because in an ideal world we wouldn't want to release this to CRAN and then a lot changes in the next version of phylocom, which means changing the user facing methods in this package.

camwebb commented 7 years ago

I will commit to leaving all CLI interactions (and executable names) unchanged. See: https://github.com/phylocom/phylocom/issues/22

sckott commented 7 years ago

thanks @camwebb