search

ropensci / piggyback

:package: for using large(r) data files on GitHub
https://docs.ropensci.org/piggyback
GNU General Public License v3.0
185 stars 26 forks source link

`pb_upload()` should pass dots `...` to `pb_release_create()` #104

Closed mrcaseb closed 1 year ago

mrcaseb commented 1 year ago

AS far as I understand, pb_upload() checks if a release exists and offers the option to create it if it doesn't exist.

However, there is no way to pass args to pb_release_create() so a release created with pb_upload() will always use defaults of pb_release_create().

I think it would make sense to pass dots to pb_release_create()

tanho63 commented 1 year ago

thinking about this more, I think I'd prefer to see the interactive release creation removed altogether rather than adding more args to pb_release_create(), and instead just erroring with a useful error message if the release doesn't exist - less "magical" experience that way

cboettig commented 1 year ago

yup, makes sense to me.