search

ropensci / piggyback

:package: for using large(r) data files on GitHub
https://docs.ropensci.org/piggyback
GNU General Public License v3.0
185 stars 26 forks source link

CRAN Submission #84

Closed 1beb closed 2 years ago

1beb commented 2 years ago

Hey Carl!

Do you have a plan for when you'll submit this to CRAN next?

The package wru relies on this one, and #77 is happening across platforms and we don't want our users to have to set github personal access tokens. (It works as expected in current master).

I'm happy to do the submission for you here if you don't have time. Let me know!

cboettig commented 2 years ago

@1beb thanks for the ping.

@tanho63 do you think we should release now or wait until we can merge #83?

tanho63 commented 2 years ago

I think deleting releases is worth adding to the cran release and that feature is pretty much ready to me.

Merging #83 is primarily held up because the newly rewritten tests don't have access to the right token, I think. If you can add a github pat to this repo's secrets under CBOETTIG_TOKEN, I think I can make it work with the cboettig/piggyback-tests repo this weekend and get the tests passing?

tanho63 commented 2 years ago

Alternatively, could consider giving me GH permissions to add one of my tokens (or putting in a token I send to you by message) and I can have it work off of one of my test repos instead?

tanho63 commented 2 years ago

@1beb v0.1.4 is now on CRAN as of July 19 (yesterday) - it may take a little bit for binaries to build. You could theoretically require this as minimum version, if desired.

Closing as resolved 🎉

1beb commented 2 years ago

Thank you Tan! Good work!