Browse argument 'vars' is not working

ropensci / popler

The R package to browse and query the popler database

https://docs.ropensci.org/popler

MIT License

8 stars 7 forks source link

Browse argument 'vars' is not working #14

Closed bibsian closed 6 years ago

bibsian commented 7 years ago

Get 'vars' argument in browse working with code.

This includes writing unit test.

bochocki commented 7 years ago

I think that vars is working now. It was mostly cleaning up variable names and making sure logic was being executed properly. A lot of the work related to some changes in elastic_tab() execution. More details here: https://github.com/AldoCompagnoni/popler/issues/16#issuecomment-285934085

Haven't built the unit test

bochocki commented 7 years ago

Need to call vars both before and _after nest_taxa(). Needs to be called before nest_taxa() since users may want to only return specific levels of taxonomy. Needs to be called after nest_taxa() since users may not want to return "taxonomy".