search

ropensci / popler

The R package to browse and query the popler database
https://docs.ropensci.org/popler
MIT License
8 stars 7 forks source link

Intuitive comments and vocabulary in `get_data` #32

Closed AldoCompagnoni closed 7 years ago

AldoCompagnoni commented 7 years ago

Need to work more work on providing intuitive

  1. Comments to each line of get_data
  2. Names of functions in get_data
  3. Change names structure from verb_object (e.g. update_call) to object_verb (e.g. call_update).
bochocki commented 7 years ago

I removed the list of "Unused Functions" in get_data.R

AldoCompagnoni commented 7 years ago

Changed names in get_data

  1. potential_vars to possible_vars
  2. all_columns to all_vars
  3. default_columns to default_vars
  4. actual_vars to subset_vars.
  5. inherit_vars expr_vars
  6. inherit_search to expr_vars_get
  7. search_argument to search_expression
  8. all_calls to updated_calls
  9. search_arg to sql_condition
  10. select_vars to vars_select
  11. query_vars to vars_query
  12. query_popler to popler_query
AldoCompagnoni commented 7 years ago

Finally, I also changed the language in two comments, to make it more intuitive. Commit is here. https://github.com/AldoCompagnoni/popler/commit/a03b07cc55f1ca9b8623495ca9b9041eae89a019

I suggest to close this issue.