Open AldoCompagnoni opened 7 years ago
Completed 1, 2, and 3, but I'm not sure I implemented (3) as intended. Unlike dictionary
, fancy_dictionary
does not currently allow users to choose which variables to display; they can only set full_tbl = TRUE
or full_tbl = FALSE
Quick thought: tf the goal is to only give the user two dictionary options ("full" or "not full"), then we can save time by building each version of the dictionary once instead of rebuilding it every time the user calls fancy_dictionary()
. We could have some function, update_dictionary()
, that runs whenever update_summary_table()
runs, and we could save the html files in main popler directory.
update_dictionary()
idea! You should do it if you find time.fancy_dictionary()
does not work on my machine. It throws the following error:pandoc.exe: Could not fetch C:/Program C:/Program: openBinaryFile: does not exist (No such file or directory) Error: pandoc document conversion failed with error 67
Error 67 is known, but I still can't fix it (some info on https://github.com/ramnathv/rcstatebin/issues/6)
fancy_dictionary
and fancy_browse
now both work, but one more hurdle:
Getting the logo image to appear. Padoc.exe does not work when path has "Program Files" in it. We need to find a way add "%20" in the path.
We need to edit the "browse.html" and "dictionary.html" documents after they're created but before they're displayed. We need to replace any spaces in the system.file("",package="popler")
path with %20
.
We need a function akin to
fancy_browse
, but working fordictionary
. This function should:fancy_dictionary
should return a different list in casefull_tbl = FALSE
orfull_tbl = TRUE
.