check argument validity at top of browse() function

ropensci / popler

The R package to browse and query the popler database

https://docs.ropensci.org/popler

MIT License

8 stars 7 forks source link

check argument validity at top of browse() function #9

Closed bochocki closed 6 years ago

bochocki commented 7 years ago

There is a lot of validity testing and control flow embedded within functions, especially later on in the browse function. Move these tests to the top of the code.

bochocki commented 7 years ago

Moved the following stop error from key_arg() to top of browse():

browse() cannot simultaneously subset based on both a logical statement and the 'keyword' argument.
Please use only one of the two methods, or refine your search using get_data().

moved the err_full_tab() check to the top of the browse function.

bochocki commented 7 years ago

suggest closing this issue