search

ropensci / prism

Download data from the Oregon PRISM climate data project http://www.prism.oregonstate.edu/
https://docs.ropensci.org/prism
Other
56 stars 25 forks source link

User can specify base URL #103

Closed adamlilith closed 1 year ago

adamlilith commented 3 years ago

Added argument to get_prism_dailys, get_prism_monthlys, and get_prism_annual to allow users to specify the service (ULR) from which the download is obtained. This allows users to specify the URL for the subscription version of PRISM (800-m daily, monthly, and annual). If not specified, the URL for the 4-km resolution, free version is used.

rabutler-usbr commented 3 years ago

Thanks for this @adamlilith. I like the idea! I just submitted v0.2.0 to CRAN, but will get it wrapped into the dev version here soon-ish.

adamlilith commented 3 years ago

Thanks!

rabutler-usbr commented 3 years ago

I'll reopen if that's ok, so that I can merge this into my main branch.

adamlilith commented 3 years ago

No problem! This is my first time making a PR on someone else's repo, so I'm new to this.

adamlilith commented 3 years ago

Hi Alan,

I realized some of the changes I suggested to allow users to download from the public or the subscription service weren't working in prism_get_monthlys and prism_get_annuals. Fixed!

rabutler-usbr commented 3 years ago

Awesome, thank you for the update @adamlilith!