search

ropensci / prism

Download data from the Oregon PRISM climate data project http://www.prism.oregonstate.edu/
https://docs.ropensci.org/prism
Other
56 stars 25 forks source link

Unable to download, possible error with prism_not_downloaded() #112

Closed bglarkin closed 1 year ago

bglarkin commented 1 year ago

When I exectute:

prism_set_dl_dir("~/Desktop/prism_temp") prism_set_dl_dir("~/Desktop/prism_temp") get_prism_normals(type = "ppt", resolution = "4km", annual = TRUE, keepZip = FALSE)

I get the message

already exists. Skipping downloading.

But I have not yet downloaded any files. I see that the function prism_not_downloaded() controls this, but I can't see what to do about it.

Liu22Yi commented 1 year ago

I met the same problem.

Liu22Yi commented 1 year ago

Here is the code I run:

install.packages("prism") library(prism)

prism_set_dl_dir("~/prism", create = TRUE)

get_prism_normals("tmean", "4km", annual = TRUE, keepZip = FALSE)

Here is what I get:

library(prism) Be sure to set the download folder using prism_set_dl_dir().

prism_set_dl_dir("~/prism", create = TRUE) creating ~/prism

get_prism_normals("tmean", "4km", annual = TRUE, keepZip = FALSE) | | 0% already exists. Skipping downloading. |==============================================================| 100%

ClairePalandri commented 1 year ago

I have the exact same problem with get_prism_normals()

Am downloading them manually in the meantime (https://prism.oregonstate.edu/normals/). However, it isn't clear whether the website and the R package would generate the same files, as the website indicates that the current PRISM normals cover the period 1991-2020, whereas the R function still says "30-year normals are currently computed using 1981-2010", as pointed out in issue #111.

rabutler commented 1 year ago

@ClairePalandri @bglarkin @Liu22Yi - will you list what operating system and version of R you are using, please?

rabutler commented 1 year ago

@ClairePalandri - the R package downloads the data directly from Oregon State, so you will get the same data. The documentation is out of date. You'll get 91-2020 normals.

bglarkin commented 1 year ago

@rabutler sure thing, thank you. mac OS 13.2.1 (22D68) R version 4.2.2 (2022-10-31)

Also thank you for confirming that direct downloads from Oregon State retrieve the same data.

ClairePalandri commented 1 year ago

@ClairePalandri @bglarkin @Liu22Yi - will you list what operating system and version of R you are using, please?

I have had the same issue on two machines:

rabutler-usbr commented 1 year ago

@bglarkin @ClairePalandri @Liu22Yi - Thank you all for flagging this issue!

I reached out to Oregon State and they fixed an issue with the API for normals. The R functions should be working again.

Please re-open if they are not for you.

bglarkin commented 1 year ago

@rabutler-usbr all works as expected now. Thank you very much!