search

ropensci / qualtRics

Download ⬇️ Qualtrics survey data directly into R!
https://docs.ropensci.org/qualtRics
Other
215 stars 70 forks source link

could the call to qualtrics_api_credentials happen in a test setup file? #198

Closed maelle closed 3 years ago

maelle commented 3 years ago

rather than in several test files?

Sorry if this is a naive question

juliasilge commented 3 years ago

This is not naive at all, and I just tried it. It turns out that some of the tests (quite of lot of them, it turns out) check setting and changing the credentials themselves so it didn't work out for me to set them once in a setup file. (The credentials would be different and not what we need after running the tests that would change the credentials, which are stored in environment variables.)

I did, however, realize how silly it is to set the credentials over and over again multiple times in the same file, so I cleaned up the test files a bit. 🙌 It's an improvement, at least!!