ropensci / rcrossref

R client for various CrossRef APIs

https://docs.ropensci.org/rcrossref

Other

165 stars 21 forks source link

fix Crossref documentation links #199

Closed salim-b closed 4 years ago

salim-b commented 4 years ago

and use Markdown to format links and always use HTTPS

sckott commented 4 years ago

thanks @salim-b for this

Updating links is great, but please change back links to not be markdownified because when submitting to CRAN if any link in an <a> tag is down for even a second during that check they reject the submission and i have to resubmit all over again. And anyway, raw links are shown as clickable links on github anyway - and in html on the docs page https://docs.ropensci.org/rcrossref/

codecov-io commented 4 years ago

Codecov Report

Merging #199 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   54.77%   54.77%           
=======================================
  Files          30       30           
  Lines        1329     1329           
=======================================
  Hits          728      728           
  Misses        601      601

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fabfc3...73da6fd. Read the comment docs.

salim-b commented 4 years ago

please change back links to not be markdownified because when submitting to CRAN if any link in an <a> tag is down for even a second during that check they reject the submission and i have to resubmit all over again.

Ok, I've changed them back to raw style.

sckott commented 4 years ago

thanks very much for your contribution