search

ropensci / rdefra

rdefra: Interact with the UK AIR Pollution Database from DEFRA
https://docs.ropensci.org/rdefra
16 stars 6 forks source link

Vignette failure #14

Closed maelle closed 2 years ago

maelle commented 2 years ago

:wave: @cvitolo!

We see a vignette failure https://github.com/r-universe/ropensci/runs/5447146461?check_suite_focus=true

Locally I can build the vignette, and I re-launched the workflow above but the timeout appeared again.

If the web service rdefra is wrapping is known to be slow/not always working, maybe you could pre-compute the vignette? https://ropensci.org/blog/2019/12/08/precompute-vignettes/

cvitolo commented 2 years ago

Hi @maelle , thanks for spotting this.

This is now fixed by recompiling the vignette, as you suggested.