search

ropensci / rdefra

rdefra: Interact with the UK AIR Pollution Database from DEFRA
https://docs.ropensci.org/rdefra
16 stars 6 forks source link

Remove rgdal dependency #19

Closed olivroy closed 5 months ago

olivroy commented 5 months ago

Not sure I can be the maintainer as I did not understand how the source website may have evolved and what the expected results are. The tests and examples are lacking a little. I haven't gone through the article and vignette however.

However, I was able to fix #17 easily (the package doesn't seem to be using any rgdal functions)

I added a few refactoring here and there that may open the way to updating the package.

maelle commented 5 months ago

oh I had missed this @olivroy sorry! Do you want write access?

maelle commented 5 months ago

Thanks so much :pray:

olivroy commented 5 months ago

@maelle Sure

maelle commented 5 months ago

@olivroy sent you an invitation to the GitHub organization, and a team with admin access.

Can you send me your email address so we can invite you to rOpenSci slack workspace?

You're not forced to become a maintainer, but it's better you get the actual experience before you make a decision. :innocent:

olivroy commented 5 months ago

Sure! Are we good with merging this first?

maelle commented 5 months ago

You can merge this PR, unless you want me to review first? In which case I'd have a look next week.

maelle commented 5 months ago

@olivroy

Can you send me your email address so we can invite you to rOpenSci slack workspace?

maelle commented 5 months ago

Invite sent!