search

ropensci / rdefra

rdefra: Interact with the UK AIR Pollution Database from DEFRA
https://docs.ropensci.org/rdefra
16 stars 6 forks source link

Merge README_files folder to assets? #3

Closed haozhu233 closed 7 years ago

haozhu233 commented 7 years ago

Hi, @cvitolo, The README_files folder and the assets folder seem to be the same thing. Maybe you want to merge them? ;)

cvitolo commented 7 years ago

Hi @haozhu233, I did not merge them because the README_files folder contains figure generated by the Rmd while assets/figures contains screenshots I have created and that I use for the README as well as the vignettes. Is this considered bad practice?

haozhu233 commented 7 years ago

Haha, I won't consider that as a bad practice at all and your explanation makes sense. I just sort of feel like these hosted images don't "deserve" two main folders in the root directories. If you don't feel in the same way, feel free to ignore that~ 😋