Emulate `readxl::read_xlsx()`

chainsawriot commented 10 months ago

These are the current arguments of readxl::read_xlsx() (v1.4.3)

read_xlsx(
  path,
  sheet = NULL,
  range = NULL,
  col_names = TRUE,
  col_types = NULL,
  na = "",
  trim_ws = TRUE,
  skip = 0,
  n_max = Inf,
  guess_max = min(1000, n_max),
  progress = readxl_progress(),
  .name_repair = "unique"
)

This is readODS::read_ods()

https://github.com/ropensci/readODS/blob/38cefb8f1a5f929b97d8c197ad7217bfae18ed19/R/read_ods.R#L274-L286

We have some more, but there are parameters we could potentially add:

[ ] trim_ws
[x] n_max
[ ] ~~guess_max~~
[ ] progress

Except progress, all of them look easy to add.

pbrohan commented 10 months ago

readr::type_convert sadly doesn't have a guess_max argument, and so we won't be able to add that either unless we rewrite the type guessing (which I am not recommending we do).

chainsawriot commented 3 weeks ago

Reopen this, because of gesistsa/minty#33

ropensci / readODS

Emulate `readxl::read_xlsx()` #154