search

ropensci / rebird

Wrapper to the eBird API
https://docs.ropensci.org/rebird
Other
82 stars 17 forks source link

GitHub Action checks failing due to missing API key #100

Closed sebpardo closed 6 months ago

sebpardo commented 8 months ago

GitHub Actions checks are failing as they require an eBird API key to properly run the tests. I'm unsure of how to securely store an API key for those checks without making it public.

slager commented 8 months ago

Checks now passing on GitHub Actions, but currently it is cheating by skipping most tests on CI.

I think this issue could be closed and can update progress towards making the tests pass (without sharing credentials) on #91.

I already have a local branch where I have the ebirdchecklistfeed tests working without sharing credentials, using the vcr package, which will work on CI and CRAN as well. I can get that working for all tests and submit another PR.

slager commented 8 months ago

Two GitHub Actions runs seemed to fail for non-rebird reasons. Maybe try rerunning the failed ones?

https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs

sebpardo commented 8 months ago

The error is in ubuntu-latest (release) and ubuntu-latest (oldrel-1) and it's an issue when setting up R dependencies with installing the withr package:

Error: 
  ! error in pak subprocess
  Caused by error in `verify_extracted_package(filename, pkg_cache)`:
  ! 
  '/tmp/Rtmp6pgtjM/file13bc3a8e8aa6/src/contrib/x86_64-pc-linux-gnu-ubuntu-22.04/4.3/withr_3.0.0.tar.gz'
  is not a valid binary, it is missing withr/Meta/package.rds.

For some reason the ubuntu-latest (devel) build extracts withr just fine and passes. I think we can safely ignore these two build fails?

slager commented 8 months ago

Yes, I think can be ignored. Or could try re-running the failed actions (see above comment) and see if that produces a nice green check mark.

sebpardo commented 8 months ago

That sorted it, all are passing.