search

ropensci / rebird

Wrapper to the eBird API
https://docs.ropensci.org/rebird
Other
82 stars 17 forks source link

Add ebird-checklist #107

Closed RichardLitt closed 8 months ago

RichardLitt commented 8 months ago

Description

Apologies for the PR template mess-up: I was using my terminal and meant to PR to @Rafnuss's PR in #93. I added a test to his and added magrittr, which was messing up. See #93.

This is my first PR to a project using R, so let me know if I've messed anything up.

Related Issue

Example

RichardLitt commented 8 months ago

Note: I've opened a PR with this content on #93 now, so if that's merged we can just close this one.

slager commented 8 months ago

@RichardLitt Your fork is based on an old version of rebird. You'll first need to merge in the more recent changes from rebird/master into your fork and resolve any merge conflicts.

Once you do that, the new continuous integration tests should show up in this PR.

Based on the failed tests in #93 you'll also probably need to add Roxygen documentation for the sleep argument.

Rather than add magrittr as a new dependency to rebird, I'd recommend removing the magrittr stuff and using the new base R pipe |>

slager commented 8 months ago

@RichardLitt We're still working lately on getting the automated testing working with the key (#104) or without a key (#105) on GitHub Actions. You could add a skip_on_ci() inside your testthat block for now (see #101 for examples) so that it doesn't fail due to no key. That way the CI will at least do an R CMD check on your function.

RichardLitt commented 8 months ago

@slager Done everything, I think. See #108.