extensions to ebirdhotspotlist

ropensci / rebird

Wrapper to the eBird API

https://docs.ropensci.org/rebird

Other

82 stars 17 forks source link

extensions to ebirdhotspotlist #89

Closed dbradnum closed 3 years ago

dbradnum commented 3 years ago

Adapt ebirdhotspotlist to use lat/lng from IP address if neither regionCode nor lat/lng coords provided.

Description

This implements the changes discussed in #87 here As well as the headline change, this also removes the duplicate locID column, and includes additional error handling and tests.

dbradnum commented 3 years ago

Thanks for the review, @sebpardo ! I've dealt with all the helpful suggestions, and left a couple of comments inline above.

Is there anything else I need to do next here? For instance, I can see that I can potentially mark each comment as 'resolved', and also resubmit the PR for re-review. This process is new for me, so let me know if there's another step to take.

sebpardo commented 3 years ago

Looks good to me, merging in. Thanks again for your contributions!