search

ropensci / redland-bindings

Redland librdf language bindings
http://librdf.org/bindings/
Other
17 stars 3 forks source link

Fix linking of R package on Windows to use libraries from system/Rtools. #104

Closed kalibera closed 9 months ago

kalibera commented 9 months ago

This makes R >= 4.2 use libraries available in the system (/Rtools) when linking the R package, rather than downloading pre-compiled versions. This fixes the package to build on aarch64.

With the patch applied, the package builds and checks fine on my Windows/aarch64 in R-devel. Also with R 4.2 and 4.3 on Windows/x86_64.

mbjones commented 9 months ago

Thanks, @kalibera -- the ucrt aarch64 fix was already in the tree from @jeroen under #102 , so all I had to do was clean up some documentation and submit the release 1.0.17-18, which just got approved. I appreciate the patch, though. Thanks!

kalibera commented 9 months ago

While that other commit seems to be addressing the problem with building on aarch64 as well, it is still a violation of the CRAN repository policy, because it is downloading pre-compiled binaries (for Rtools42 and Rtools43 before pkg-config was available).

Also, let me state that I find publishing o private emails (including CRAN-private emails), without explicit permission of all parties, inappropriate.