Update build procedure - Githubissues

gothub commented 6 years ago

Ensure that the build procedure works from a 'clean' build, including a regeneration of the src/redland.c file that involves running swig.sh. The make 'clean' target does not remove this, but maybe it should. Other issues to resolve:

roxygen2 6.1.0 has changed the processing of user defined roclets, so the redland roclet may need to be updated. Running the command roxygenize(roclets=c("collate", "rd", "namespace", "mergeNamespace_roclet")) produces the error:

Error in roclet_process.roclet_mergeNamespace(X[[i]], ...) : 
  unused arguments (blocks = blocks, env = env)

a new version of swig (3.0.12) produces a somewhat different src/redland.c than swig 3.0.6, as shown in this PR

The build will first be updated on macOS, then the Docker based build/tests will be updated, which is described here

mbjones commented 6 years ago

I'm pretty sure that swig.sh is no longer in use -- rather, the swig bindings are generated by running autoconf and make. I had to remove the redland.c file (and .o and .so), but then the build system rebuilt them for me.

gothub commented 6 years ago

Yep, that is correct, swig is called directly from the generated Makefile. I'm removing swig.sh.

ropensci / redland-bindings

Update build procedure #77