ropensci / refsplitr

R package for processing, organizing, and visualizing reference records downloaded from the Web of Science.
https://docs.ropensci.org/refsplitr
Other
55 stars 6 forks source link

Docs building failure #83

Closed maelle closed 2 years ago

maelle commented 2 years ago

:wave: @embruna!

We're seeing some failures in https://github.com/r-universe/ropensci/actions/runs/1574868026 in particular when trying to build the pkgdown website https://github.com/r-universe/ropensci/runs/4511976198?check_suite_focus=true (maybe the vignette should be pre-built? Cf https://ropensci.org/blog/2019/12/08/precompute-vignettes/)

I also see you're using Travis, which we no longer recommend https://ropensci.org/blog/2020/11/19/moving-away-travis/ so for future checks you might want to explore e.g. GitHub Actions see https://usethis.r-lib.org/reference/github_actions.html and https://github.com/r-lib/actions/tree/v2-branch/examples

Happy to provide guidance if needed.

embruna commented 2 years ago

Hi @maelle, I'll deal with this as soon as I return from vacation on January 2. If it needs to be done sooner, just let me know.

maelle commented 2 years ago

:wave: @embruna! A friendly reminder in case this slipped through the cracks, and a Happy New Year in any case!

embruna commented 2 years ago

Happy New Year, @maelle! I've switched over from Travis to Github Actions. I think I scribbed Travis completely, the one doubt I had was what to do with the appveyor.yaml but I will look into that in a bit.

embruna commented 2 years ago

As for the failures, i think they are definitely the vignette and will try the pre-built option ASAP.

maelle commented 2 years ago

:wave: @embruna!

the one doubt I had was what to do with the appveyor.yaml but I will look into that in a bit.

I think you can remove this too as GitHub Actions also supports CI on Windows.

maelle commented 2 years ago

The docs website is up, thank you!

embruna commented 2 years ago

Removed appveyor.yaml . Still trying to figure out why failing but getting closer

maelle commented 2 years ago

Maybe you need to deactivate the repo in Appveyor interface? It's under your Appveyor account right? (If I remember correctly we no longer transferred them to ropensci account even when we still used Appveyor)