search

ropensci / refsplitr

R package for processing, organizing, and visualizing reference records downloaded from the Web of Science.
https://docs.ropensci.org/refsplitr
Other
55 stars 6 forks source link

Squashes all R CMD CHECK warnings #85

Closed Aariq closed 2 years ago

Aariq commented 2 years ago

Did some work to remove all warnings on devtools::check(). There are still the two failing tests though.

Things I did:

  1. ran usethis::use_roxygen_md to get markdown in documentation working
  2. added LazyData: true to description to fix some warnings (see: https://stackoverflow.com/questions/57396392/warning-variables-with-usage-in-documentation-object-fang-but-not-in-code)
  3. removed square brackets from docs that were getting read as links (because I turned on markdown, oops)
  4. added some files to .Rbuildignore
Aariq commented 2 years ago

let's make sure the tests pass before merging

Aariq commented 2 years ago

looks all good except the two failing tests. Warnings and errors all fixed I think

embruna commented 2 years ago

Eric, thanks very much. Will merge and see what happens...