search

ropensci / rentrez

talk with NCBI entrez using R
https://docs.ropensci.org/rentrez
Other
195 stars 38 forks source link

typo check #41

Closed htc502 closed 9 years ago

htc502 commented 9 years ago

Hi, sorry for the .last function change... I have reverted my branch and pull request now with only typo checks..

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 98.79% when pulling 9835269381e9a1c3f436d37191efcc3d2d86de51 on htc502:master into 813af786131eb39beae7a24625d7bfd5d1eef9f4 on ropensci:master.

dwinter commented 9 years ago

Merged thanks!

How can I credit you for your contribution? If you are OK with publicaly sharing your name/email I can add you to the package as a contributor,

person("First", "Last", role=c("ctb"),   email = "account@mail.com")

If you'd rather stay under the radar I can include your GH handle in the acknowledgements of the paper I'll write for this package?

htc502 commented 9 years ago

glad to be merged. person(“han”,“guangchun”, role=c(“ctb”),email=“hanguangchun@gmail.com”) besides,i am interested in eutils related projects as i have to convert ids frequently. i wrote an excel plugin to do id convertion using eutils. it，s my first time to collabrate with guys working on r package dev. many things to learn... thinking about adding examples for id convertion and snp annotation, don't know if it is already in your schedue.

dwinter commented 9 years ago

You're in :smile:

I want to add some "simple" id-conversion examples to the vignette (see #28). I think I will re-write a lot of the vignette, so if you wanted to work on that it might more sense to start a new file (either in /vignettes or seperate from the repo for now).

I don't want to dissuade you from using rentrez, but you might also find biomaRt helpful for this.

htc502 commented 9 years ago

thanks for the suggestion. I'll have a try.