ropensci / rix

Reproducible development environments for R with Nix
https://docs.ropensci.org/rix/
GNU General Public License v3.0
136 stars 12 forks source link

Improve readability: Git package dependencies on separate lines #158

Closed artur-sannikov closed 3 months ago

artur-sannikov commented 5 months ago

Now, if a package from GitHub has many dependencies, it results in a very long line after propagatedBuildInputs = builtins.attrValues. It's possible in nix to have each of these packages on a separate line, which significantly improves code readability.

For example,

    propagatedBuildInputs = builtins.attrValues {
    inherit (pkgs.rPackages)
      SummarizedExperiment
      SingleCellExperiment
      TreeSummarizedExperiment
      MultiAssayExperiment
      MASS
      ape
      decontam
      vegan
      BiocGenerics
      S4Vectors
      IRanges
      Biostrings
      DECIPHER
      BiocParallel
      DelayedArray
      DelayedMatrixStats
      scuttle
      scater
      DirichletMultinomial
      rlang
      dplyr
      tibble
      tidyr
      bluster
      MatrixGenerics;
    };
b-rodrigues commented 4 months ago

partially fixed, but buildInputs of github packages need the same treatment

philipp-baumann commented 3 months ago

174

philipp-baumann commented 3 months ago

I addressed this in #195 thanks for the input @artur-sannikov