ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

coops changes #126

Closed sckott closed 8 years ago

sckott commented 8 years ago

@jsta can we change some things

jsta commented 8 years ago

The idea would be to convert character results to numeric? I'll go through the various product results and see how the numeric columns lineup.

jsta commented 8 years ago

Also, I see that calls to water level products should throw an error if a datum is not supplied. Currently there is just a silent "no data" return.

sckott commented 8 years ago

The idea would be to convert character results to numeric?

yes

jsta commented 8 years ago

Another issue is that the datums and predictions product return a data.frame not named "data"

jsta commented 8 years ago

Not all of the data columns are numeric for all products. For example, all of the products except for monthly_mean return a character POSIXct date-stamp as the first column.

sckott commented 8 years ago

thanks, closing